Implement favorites on Android #1236

cmonfortep · 2021-05-13T12:24:02Z

Task/Issue URL: https://app.asana.com/0/488551667048375/1200182978612539/f
Tech Design URL:
CC:

Description:
This PR introduces favorites in the Android app.
List of new features:

Bookmark screen redesigned to show favorites
Users can add favorites from the overflow menu
Favicon logic improved to fetch high-res favicons
Quick access grid on the home tab (and on the SystemSearchActivity)
Quick access grid allow users to drag-drop and rearrange favorites (also edit and delete via long-press)
autocomplete shows favorites as results
Focusing the URL bar when browsing also show a grid with favorites

Steps to test this PR:

Fresh install

Fresh install
Visit any website and add it as favorite
During onboarding, favorites will not appear in the home tab if any Dax cta is active
Finish onboarding
Ensure favorites are shown in the home tab screen
Go to bookmarks screen, ensure favorites are listed

Re-arrange favorites

Add more favorites
Go to a new tab
Re-arrange favorites using drag and drop
Go to bookmarks screen
Ensure favorites list reflects previous changes (position)

Edit/Delete

You can edit/delete (and undo) favorites
Ensure those actions work from the home tab and from bookmarks screen

Autocomplete

Having multiple favorites
Go to URL bar and introduce any word part of favorites (title or URL)
ensure favorites appear in the suggestions
When browsing, focus the URL bar
Ensure favorites are shown
if you start typing, suggestions will appear instead
clearing the input text will show favorites again

Favicon

When adding websites as favorites, we know accept normal favicon (bitmap) and high-res favicons(apple-touch)
Visit tesla.com and add it as favorite
Ensure high-res favicon is persisted (previously, for this site, a low-res favicon was used)
For websites without favicon (or that we haven't still stored any favicon) ensure a new default favicon appears
Default favicon shows a letter and a random color

Database migration

Check out develop
run the app
add some bookmarks
Check out this branch
run the app
Ensure bookmarks are still present
Ensure migration did not crash

Internal references:

Software Engineering Expectations
Technical Design Template

- Create entity - Create DAO

- bookmarks listed with section title

- Added logic to display empty hint in favorites adapter - Updated new UI elements to be displayed correctly and with expected copy

… favorites - be able to reuse dialog - be able to reuse command logic - be able to reuse same listeners - decouple from entity data objects from databases in UI

- if user moves the item, hide menu

# Conflicts: # app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt

… browsing

Marchuck · 2021-05-19T11:00:47Z

app/src/main/java/com/duckduckgo/app/bookmarks/model/FavoritesRepository.kt

+
+interface FavoritesRepository {
+    fun favoritesCountByDomain(domain: String): Int
+    fun favoritesObservable(): Single<List<SavedSite.Favorite>>


shouldn't be favoritesSingle ?

malmstein

Great work @cmonfortep, there is a lot of good stuff in here! As we discussed offline, there's a part regarding adding more RX code that we need to discuss internally. Other than that I've got a few suggestions that won't block the PR but I'd like you to consider.

malmstein · 2021-05-21T12:40:23Z

app/src/androidTest/java/com/duckduckgo/app/autocomplete/api/AutoCompleteApiTest.kt

    fun whenReturnBookmarkSuggestionsThenPhraseIsURLBaseHost() {
        whenever(mockAutoCompleteService.autoComplete("title")).thenReturn(Observable.just(emptyList()))
        whenever(mockBookmarksDao.bookmarksObservable()).thenReturn(Single.just(listOf(BookmarkEntity(0, "title", "https://example.com"))))
+        whenever(mockFavoritesRepository.favoritesObservable()).thenReturn(Single.just(emptyList()))


as discussed on MM, let's discuss with the rest of the team if we want to refactor AutoComplete API and get rid of Rx or not.

app/src/androidTest/java/com/duckduckgo/app/bookmarks/model/FavoritesDataRepositoryTest.kt

app/src/androidTest/java/com/duckduckgo/app/browser/favicon/DuckDuckGoFaviconManagerTest.kt

app/src/androidTest/java/com/duckduckgo/app/systemsearch/SystemSearchViewModelTest.kt

app/src/main/res/layout/fragment_browser_tab.xml

app/src/main/res/layout/include_quick_access_items.xml

app/src/main/res/layout/view_item_divider.xml

app/src/main/res/values/strings.xml

# Conflicts: # app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt # app/src/main/res/layout/include_new_browser_tab.xml

…sRepository

# Conflicts: # app/schemas/com.duckduckgo.app.global.db.AppDatabase/34.json # app/src/androidTest/java/com/duckduckgo/app/browser/BrowserTabViewModelTest.kt # app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt # app/src/main/java/com/duckduckgo/app/global/db/AppDatabase.kt # app/src/main/res/values/string-untranslated.xml

cmonfortep added 30 commits April 12, 2021 14:04

- Modify database to store favorites

5eb8f7a

- Create entity - Create DAO

Add favorite added to overflow menu

70d9d8d

avoid reusing copy used in bookmarks screen in the browser screen

6549632

configure dependency injection for FavoritesRepository

0e33efe

Allow users to add a favorite

9cd4cae

show favorite confirmation message when added

ca10d30

Temp approach to show favorites and bookmarks in same screen

4322f45

Merge branch 'develop' into feature/cristian/favorites

b4614af

add recycler view dependency (to use ConcatAdapter)

27221fb

fix migration error

fbdacf6

(wip) refactor to use ConcatAdapter:

275f028

- bookmarks listed with section title

Add empty case hint as part of recycler view.

2b30d23

- Extracted adapters out from BookmarkActivity class

f5bb832

- Added logic to display empty hint in favorites adapter - Updated new UI elements to be displayed correctly and with expected copy

changed bookmark dialog copies to be generic

fb57c8e

Refactor: introduced savedSite as sealed class to model bookmarks and…

c317d46

… favorites - be able to reuse dialog - be able to reuse command logic - be able to reuse same listeners - decouple from entity data objects from databases in UI

apply codestyle

beace14

Update only changed items in list

1e190c2

disable animator list to keep previous behavior

a02ec9e

Merge branch 'develop' into feature/cristian/favorites

9521229

Show favorites as quick access items in SystemSearchActivity (wip)

19b0626

centering items in recyclerview

7fd8e6f

drag-drop in System search activity

de62a44

UI improvements on quick access view

7405d30

show/hide context menu depending on user interactions:

d82870f

- if user moves the item, hide menu

inline method

9335ee4

fix: show quickaccess items when closing autocomplete

9b6008c

edit/delete quickaccess items in SystemSearchActivity screen

74603e9

show quickAccess items in BrowserTabFragment

e798955

Merge branch 'develop' into feature/cristian/favorites

e44ba46

# Conflicts: # app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt

fix: be able to drag and drop when user goes back to home screen from…

a45ce03

… browsing

cmonfortep added 9 commits May 17, 2021 12:28

remove unnecessary suspend operator

356e745

Quick access grid show title in 2 lines

1b0d9f6

added new tests to cover logic in BrowserTabViewModel

1f6c923

apply code style

567c3be

unit test new logic in SystemSearchViewModelTest

a37529f

add test for initial state

66d79da

fix padding for quick access grid on autocomplete

37fd840

Address product review feedback around autocomplete

b9ce0fe

fix margins on 2 lines title for grid quick access items

fbda733

cmonfortep marked this pull request as ready for review May 19, 2021 10:32

cmonfortep assigned malmstein May 19, 2021

test new changes from product review

b01a23b

Marchuck reviewed May 19, 2021

View reviewed changes

removed unnecessary logs

86ceb79

malmstein approved these changes May 21, 2021

View reviewed changes

cmonfortep added 13 commits May 24, 2021 10:38

Merge branch 'develop' into feature/cristian/favorites

e23dea5

# Conflicts: # app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt # app/src/main/res/layout/include_new_browser_tab.xml

remove unnecessary coroutine blocks from unit tests

c5b4956

add verify to ensure favicon manager removes favicon

49cc54a

Move logic to remove favicons when removing favorites inside Favorite…

3c7a63f

…sRepository

move delete logic inside viewmodel

a8a53b2

use extension functions for consistency to hide/show views

906374c

Refactor: use same command when savedSite added instead of 2

2ec8c14

use launchIn for consistency

5c50e43

Use io dispatcher when launching coroutine

0cc4f8a

move delete decision inside viewmodel and refactor test

9e8d0c3

move strings back to untranslated strings

c804fed

apply codestyle

59f8da1

cmonfortep merged commit 53b64f0 into develop May 25, 2021

cmonfortep deleted the feature/cristian/favorites branch May 25, 2021 16:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Implement favorites on Android #1236

Implement favorites on Android #1236

Uh oh!

cmonfortep commented May 13, 2021 •

edited

Loading

Uh oh!

Marchuck May 19, 2021

Uh oh!

malmstein left a comment

Uh oh!

malmstein May 21, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Implement favorites on Android #1236

Implement favorites on Android #1236

Uh oh!

Conversation

cmonfortep commented May 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Internal references:

Uh oh!

Marchuck May 19, 2021

Choose a reason for hiding this comment

Uh oh!

malmstein left a comment

Choose a reason for hiding this comment

Uh oh!

malmstein May 21, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cmonfortep commented May 13, 2021 •

edited

Loading