Skip to content

Conversation

@marcosholgado
Copy link
Contributor

@marcosholgado marcosholgado commented May 19, 2021

Task/Issue URL: https://app.asana.com/0/45878998844068/1200339867891418
Tech Design URL:
CC:

Description:
This PR removes all the code from the UOA experiment. In the task you can find two apks to facilitate testing.

Steps to test this PR:

Normal Update

  1. Install the "develop" apk and launch the app.
  2. Kill the app
  3. Install the "new" apk and launch the app.
  4. Wait 1 minute
  5. You should not see the UOA notification and the app should not crash

Normal Update Not Crashing

  1. Install the "develop" apk and launch the app.
  2. Kill the app
  3. Install the "new" apk and DO NOT launch the app.
  4. Wait 1 minute
  5. You should not see the UOA notification
  6. The logcat should show an error because it couldn't find the worker but the app won't crash.

Class not found: com.duckduckgo.app.notification.NotificationScheduler$UseOurAppNotificationWorker

Notification showing

  1. Install the "develop" apk and launch the app.
  2. Wait 1 minute
  3. You should see the UOA notification, do not dismiss the notification.
  4. Install the "new" apk.
  5. The notification should disappear

Database clean up

  1. Install from the develop branch (not the apk)
  2. Launch the app
  3. In the database inspector add the following:
  4. In the table userStage change the appStage to USE_OUR_APP_ONBOARDING
  5. Open a new query and execute:
  6. INSERT INTO user_events values ('USE_OUR_APP_SHORTCUT_ADDED', 1)
  7. INSERT INTO user_events values ('USE_OUR_APP_FIREPROOF_DIALOG_SEEN', 1)
  8. INSERT INTO dismissed_cta values ('USE_OUR_APP')
  9. INSERT INTO dismissed_cta values ('USE_OUR_APP_DELETION')
  10. Install the app from this branch
  11. In the database inspector check the following:
  12. In the table userStage the stage should be ESTABLISHED
  13. The tables user_events and dismissed_cta should not contain anything related with UOA

Database clean up 2

  1. Install from the develop branch (not the apk)
  2. Launch the app
  3. In the table userStage change the appStage to USE_OUR_APP_NOTIFICATION
  4. Install the app from this branch
  5. In the database inspector check the following:
  6. In the table userStage the stage should be ESTABLISHED

Internal references:

Software Engineering Expectations
Technical Design Template

@marcosholgado marcosholgado changed the title Feature/marcos/remove uoa experiment Remove uoa experiment May 19, 2021
@marcosholgado marcosholgado marked this pull request as ready for review May 20, 2021 07:21
@marcosholgado marcosholgado requested a review from cmonfortep May 20, 2021 07:23
…https://github.com/duckduckgo/android into feature/marcos/remove_uoa_experiment

� Conflicts:
�	app/src/androidTest/java/com/duckduckgo/app/statistics/VariantManagerTest.kt
�	statistics/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt
…https://github.com/duckduckgo/android into feature/marcos/remove_uoa_experiment

� Conflicts:
�	statistics/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt
Copy link
Contributor

@cmonfortep cmonfortep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work here @marcosholgado

Thanks for providing those apks, really helpful for testing.

@marcosholgado marcosholgado merged commit 5596ef1 into develop May 24, 2021
@marcosholgado marcosholgado deleted the feature/marcos/remove_uoa_experiment branch May 24, 2021 17:28
Copy link

@sloppyjuicy sloppyjuicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants