-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Remove uoa experiment #1241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Remove uoa experiment #1241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…https://github.com/duckduckgo/android into feature/marcos/remove_uoa_experiment
…https://github.com/duckduckgo/android into feature/marcos/remove_uoa_experiment
…https://github.com/duckduckgo/android into feature/marcos/remove_uoa_experiment � Conflicts: � app/src/androidTest/java/com/duckduckgo/app/statistics/VariantManagerTest.kt � statistics/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt
…https://github.com/duckduckgo/android into feature/marcos/remove_uoa_experiment � Conflicts: � statistics/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt
cmonfortep
approved these changes
May 24, 2021
Contributor
cmonfortep
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work here @marcosholgado
Thanks for providing those apks, really helpful for testing.
app/src/main/java/com/duckduckgo/app/browser/shortcut/ShortcutBuilder.kt
Show resolved
Hide resolved
app/src/androidTest/java/com/duckduckgo/app/global/db/AppDatabaseTest.kt
Show resolved
Hide resolved
sloppyjuicy
reviewed
May 25, 2021
sloppyjuicy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/45878998844068/1200339867891418
Tech Design URL:
CC:
Description:
This PR removes all the code from the UOA experiment. In the task you can find two apks to facilitate testing.
Steps to test this PR:
Normal Update
Normal Update Not Crashing
Class not found: com.duckduckgo.app.notification.NotificationScheduler$UseOurAppNotificationWorkerNotification showing
Database clean up
USE_OUR_APP_ONBOARDINGINSERT INTO user_events values ('USE_OUR_APP_SHORTCUT_ADDED', 1)INSERT INTO user_events values ('USE_OUR_APP_FIREPROOF_DIALOG_SEEN', 1)INSERT INTO dismissed_cta values ('USE_OUR_APP')INSERT INTO dismissed_cta values ('USE_OUR_APP_DELETION')userStagethe stage should beESTABLISHEDuser_eventsanddismissed_ctashould not contain anything related with UOADatabase clean up 2
USE_OUR_APP_NOTIFICATIONuserStagethe stage should beESTABLISHEDInternal references:
Software Engineering Expectations
Technical Design Template