Skip to content

Conversation

@cmonfortep
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/414730916066338/1200308959421574/f
Tech Design URL:
CC:

Description:
Removes unused listener inside FireDialog.

Steps to test this PR:
Nothing should have changed with this PR. The removed callback method was not being called, so removed logic was never executed.
However, as a smoke test:

  1. Run the app
  2. Clear all data (from browser / from tab screen)
  3. Ensure fire animations runs, process restarts, and nothing crashes

Internal references:

Software Engineering Expectations
Technical Design Template

@marcosholgado marcosholgado self-assigned this May 20, 2021
@marcosholgado marcosholgado self-requested a review May 20, 2021 07:33
Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cmonfortep cmonfortep merged commit b72efd6 into develop May 20, 2021
@cmonfortep cmonfortep deleted the feature/cristian/remove_unused_listener_clear branch May 20, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants