Skip to content

Enable serp variants #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2021
Merged

Enable serp variants #1245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions app/src/androidTest/java/com/duckduckgo/app/statistics/VariantManagerTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,14 @@ class VariantManagerTest {
@Test
fun serpControlVariantHasExpectedWeightAndNoFeatures() {
val variant = variants.first { it.key == "sc" }
assertEqualsDouble(0.0, variant.weight)
assertEqualsDouble(1.0, variant.weight)
assertEquals(0, variant.features.size)
}

@Test
fun serpExperimentalVariantHasExpectedWeightAndNoFeatures() {
val variant = variants.first { it.key == "se" }
assertEqualsDouble(0.0, variant.weight)
assertEqualsDouble(1.0, variant.weight)
assertEquals(0, variant.features.size)
}

Expand Down Expand Up @@ -73,14 +73,14 @@ class VariantManagerTest {
@Test
fun newInBrowserControlVariantHasExpectedWeightAndNoFeatures() {
val variant = variants.first { it.key == "zx" }
assertEqualsDouble(1.0, variant.weight)
assertEqualsDouble(0.0, variant.weight)
assertEquals(0, variant.features.size)
}

@Test
fun newInBrowserInAppUsageVariantHasExpectedWeightAndKillOnboardingAndInAppUsageFeatures() {
val variant = variants.first { it.key == "zy" }
assertEqualsDouble(1.0, variant.weight)
assertEqualsDouble(0.0, variant.weight)
assertEquals(2, variant.features.size)
assertTrue(variant.hasFeature(KillOnboarding))
assertTrue(variant.hasFeature(InAppUsage))
Expand Down
8 changes: 4 additions & 4 deletions statistics/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,16 +43,16 @@ interface VariantManager {
val ACTIVE_VARIANTS = listOf(
// SERP variants. "sc" may also be used as a shared control for mobile experiments in
// the future if we can filter by app version
Variant(key = "sc", weight = 0.0, features = emptyList(), filterBy = { isSerpRegionToggleCountry() }),
Variant(key = "se", weight = 0.0, features = emptyList(), filterBy = { isSerpRegionToggleCountry() }),
Variant(key = "sc", weight = 1.0, features = emptyList(), filterBy = { isSerpRegionToggleCountry() }),
Variant(key = "se", weight = 1.0, features = emptyList(), filterBy = { isSerpRegionToggleCountry() }),

// InAppUsage Experiments
Variant(key = "ma", weight = 0.0, features = emptyList(), filterBy = { isEnglishLocale() }),
Variant(key = "mb", weight = 0.0, features = listOf(VariantFeature.KillOnboarding, VariantFeature.RemoveDay1AndDay3Notifications), filterBy = { isEnglishLocale() }),
Variant(key = "mc", weight = 0.0, features = listOf(VariantFeature.KillOnboarding, VariantFeature.InAppUsage, VariantFeature.RemoveDay1AndDay3Notifications), filterBy = { isEnglishLocale() }),

Variant(key = "zx", weight = 1.0, features = emptyList(), filterBy = { isEnglishLocale() }),
Variant(key = "zy", weight = 1.0, features = listOf(VariantFeature.KillOnboarding, VariantFeature.InAppUsage), filterBy = { isEnglishLocale() })
Variant(key = "zx", weight = 0.0, features = emptyList(), filterBy = { isEnglishLocale() }),
Variant(key = "zy", weight = 0.0, features = listOf(VariantFeature.KillOnboarding, VariantFeature.InAppUsage), filterBy = { isEnglishLocale() })
)

val REFERRER_VARIANTS = listOf(
Expand Down