Skip to content

Conversation

@marcosholgado
Copy link
Contributor

@marcosholgado marcosholgado commented May 20, 2021

Task/Issue URL: https://app.asana.com/0/1125189844152671/1200343978632902
Tech Design URL:
CC:

Description:
This PR introduces the new autocomplete parameter is_nav. The extra isNav=true field will then be used as a navigation query (meaning when the user clicks that autocomplete suggestion we load that URL). Results where this is false should be treated as searches (even if they look like a URL).

This PR also handles the case where nav=null in which case we default to the old way.

Steps to test this PR:
Previous steps, setting up Charles

  1. Connect your device to charles and use the autocomplete.json response provided in the task.
  2. Install and launch the app.
  3. Add a bookmark to http://m.youtube.com
  4. Do a search (i.e. you) and in Charles map the response to the autocomplete.json file.

Test cases

  1. The bookmark result should take you to the URL.
  2. The first autocomplete result has isNav=false, clicking on it should do a search.
  3. The second autocomplete result has isNav=false and is a URL, clicking on it should do a search.
  4. The third autocomplete result has isNav=true, clicking on it should load the URL.
  5. The fourth autocomplete result doesn't have the nav attribute and is a URL, clicking on it should load the URL.
  6. The fifth autocomplete result doesn't have the nav attribute and is a search term, clicking on it should do a search.

Internal references:

Software Engineering Expectations
Technical Design Template

Copy link
Member

@CDRussell CDRussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working well!

@marcosholgado marcosholgado merged commit ac377f5 into develop May 21, 2021
@marcosholgado marcosholgado deleted the feature/marcos/nav_param_autocomplete branch May 21, 2021 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants