Clear out old disconnect data when new data available #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aitorvs
pushed a commit
that referenced
this pull request
Nov 18, 2021
* Remove failing, redundant test * Remove graph.facebook.com from tracker domains (force removal locally) * Remove local override of graph.facebook.com Co-authored-by: Craig Russell <CDRussell@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Issue URL: https://app.asana.com/0/414730916066338/522562831442810
Description
Clears out any existing
disconnectdata before persisting new data from the networkSteps to Test this PR:
TrackerDataDownloader.disconnectDownload()methodtrackerDataDao.getAll()trackerDataDao.deleteAll(), followed bytrackerDataDao.getAll()again to ensure no results are then returned