Fix service worker crash #1275
Merged
Fix service worker crash #1275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aitorvs
reviewed
Jun 7, 2021
Comment on lines
+39
to
+45
| try { | ||
| ServiceWorkerController.getInstance().setServiceWorkerClient( | ||
| BrowserServiceWorkerClient(requestInterceptor, uncaughtExceptionRepository) | ||
| ) | ||
| } catch (e: Exception) { | ||
| Timber.w(e.localizedMessage) | ||
| } |
Collaborator
There was a problem hiding this comment.
Nit: I quite like using runCatching instead of try-catch blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414730916066338/1200407932131592
Tech Design URL:
CC:
Description:
This PR wraps the
getInstance()call from the Service Worker to avoid crashing the app.Steps to test this PR:
Internal references:
Software Engineering Expectations
Technical Design Template