Create common-ui module for common theming across the apps #1277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malmstein
changed the title
joshliebe
reviewed
Jun 14, 2021
| fun addition_isCorrect() { | ||
| assertEquals(4, 2 + 2) | ||
| } | ||
| } No newline at end of file |
Contributor
There was a problem hiding this comment.
Does the module need a test in order for the build to pass? Or can this be removed?
Contributor
Author
There was a problem hiding this comment.
good catch, damn AS. Will remove!
joshliebe
approved these changes
Jun 14, 2021
Contributor
joshliebe
left a comment
joshliebe
left a comment
There was a problem hiding this comment.
Went through all the screens (Light and dark theme), LGTM! 👍
Contributor
Author
|
Thanks @joshliebe ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/488551667048375/1200452691263184
Tech Design URL:
CC:
Description:
As we are more features / modules that need UI theming, we find ourselves having to duplicate themes and styles. This is not very optimal, not scales really well.
This PR creates a common theme module that other modules can depend on. All the styles and themes that are common will be there. Styles that only belong to a feature (ie a button style) will still live in it's own module.
Steps to test this PR:
Internal references:
Software Engineering Expectations
Technical Design Template