Skip to content

Conversation

@CDRussell
Copy link
Member

Task/Issue URL:

Description:
Ensures the RecyclerView in the tab switcher doesn't have its scroll position set until it's ready to receive that

Steps to test this PR:

On develop

  1. Open up 12 tabs (hint, wikipedia is a good site to use to find lots of links to open in background)
  2. Switch to the tab in position 7 or 8
  3. Open tab switcher again; you might see the bug whereby it doesn't scroll (repeat a few times if you don't see it immediately)
  4. Install this branch
  5. Repeat the experiment; you should see it set scroll position correctly
  6. Repeat for other elements in the list (first, last etc...) and confirm all work as expected

Internal references:

Software Engineering Expectations
Technical Design Template

Copy link
Contributor

@cmonfortep cmonfortep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@CDRussell CDRussell merged commit 960529b into develop Jun 22, 2021
@CDRussell CDRussell deleted the feature/craig/tab_switcher_scroll_position_fix branch June 22, 2021 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Opening a background tab and going back to tabs makes tabs window to scroll to top

2 participants