Skip to content

move night-colors into common-ui module #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2021
Merged

move night-colors into common-ui module #1351

merged 1 commit into from
Aug 9, 2021

Conversation

@cmonfortep
Copy link
Contributor

@cmonfortep cmonfortep commented Aug 4, 2021

Task/Issue URL: https://app.asana.com/0/414730916066338/1200721266093175/f
Tech Design URL:
CC:

Description:
This PR just moves that night/colors file into common-ui according to our guidelines.

Steps to test this PR:

  1. Add new favorites widget to your home screen using “system default” theme
  2. Ensure system theme is honored when changing between light and dark
Internal references:

Software Engineering Expectations
Technical Design Template

malmstein
malmstein approved these changes Aug 6, 2021
View reviewed changes
Copy link
Contributor

@malmstein malmstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cmonfortep, 🚢

@cmonfortep cmonfortep merged commit 134b3e5 into develop Aug 9, 2021
@cmonfortep cmonfortep deleted the feature/cristian/move_night_colors_commonui branch August 9, 2021 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malmstein malmstein malmstein approved these changes

Assignees

@malmstein malmstein

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cmonfortep @malmstein