Latest kotlin version #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subsymbolic
approved these changes
Jan 25, 2018
aitorvs
pushed a commit
that referenced
this pull request
Nov 18, 2021
* Allow bulk insertion of debug receiver's trackers * File formatting * Ensure repository queried off of the main thread * Add @transaction annotation to all queries in VPN tracker DAO As per documentation, potentially large queries should be marked with this to ensure all data is queried in one transaction. Otherwise, when it is being chunked from the db we might end up with data integrity problems from one chunk-read to the next * Ensure post-queries from DB happen off of the main thread * Apply hard limit on how many trackers retrieved from database * Add `.conflate` and `.distinctUntilChanged` to most of our Flow queries - We want to easy any delays in processing emitted items so we don't block the emitter (room), hence conflate - We don't need to repeatedly get handed the same list over and over if nothing changed in the list, hence distinctUntilChanged * Use VPN coroutine scope instead of GlobalScope * Perform a second query to get total tracker count since we cap retrieved trackers * Fixing up tests * Tweak which dispatchers used where Co-authored-by: Craig Russell <CDRussell@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Issue URL: n\a
Description
Latest kotlin version