Skip to content

Conversation

@CDRussell
Copy link
Member

Asana Issue URL: https://app.asana.com/0/414730916066338/533891143524670

Description

MinWidth set to 0 caused the crash. setting to 1 fixes the crash without changing anything visually

Steps to Test this PR:

  1. Test on a Samsung Lollipop device that long pressing on the URL doesn't break it (neither does double tapping)

@CDRussell CDRussell requested a review from subsymbolic January 26, 2018 15:41
@CDRussell CDRussell changed the title caused by minWidth=0; setting to 1 fixes crash withi no visual changes caused by minWidth=0; setting to 1 fixes crash with no visual changes Jan 26, 2018
Copy link
Contributor

@subsymbolic subsymbolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome detective work!

@CDRussell CDRussell merged commit 3b5d901 into develop Jan 26, 2018
@CDRussell CDRussell deleted the feature/fix_samsung_lollipop_crash branch January 26, 2018 16:30
aitorvs pushed a commit that referenced this pull request Nov 18, 2021
* Batch insertion of blocked trackers, inserting into db every 1s

* Add a better name for dagger module

Co-authored-by: Craig Russell <CDRussell@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants