Skip to content

Conversation

@CDRussell
Copy link
Member

Asana Issue URL: https://app.asana.com/0/414730916066338/547397654936878
GitHub Issue: #170

Description

Add scrollbars to the webview.

Steps to Test this PR:

  1. Visit arstechnica.com to ensure scrollbar visible against black themed webpage
  2. Visit medium.com to ensure visible against white theme webpage
  3. Ensure scroll bar only visible when scrolling, and fades away when not scrolling

@CDRussell CDRussell requested a review from subsymbolic February 5, 2018 12:44
@CDRussell CDRussell mentioned this pull request Feb 5, 2018
Copy link
Contributor

@subsymbolic subsymbolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like having scrollbars!

A few things to fix (they're probably all related):
• The omnibar no longer hides on scroll
• The bottom overscroll view no longer shows properly
• The scrollbar falls off the bottom of the page

Can we also make the scrollbars a dark gray color? When the bars are really large (as they are on a page that doesn't need to scroll much) the orange is loud.

@CDRussell
Copy link
Member Author

The omnibar no longer hides on scroll

Switched out to a normal WebView during implementation and failed to switch back; 🤦‍♂️ . Fixed.

The bottom overscroll view no longer shows properly

Should work now.

The scrollbar falls off the bottom of the page

It shouldn't now.

Can we also make the scrollbars a dark gray color?

I've removed the accent color from the "thumb" and used a grey instead. It isn't dark, as the scrollbar "track" is already dark grey and we need a bit of contrast. Happy to tweak colours though, see colors.xml for their definitions if you want to experiment

<color name="webViewScrollbarTrackColor">#FF333333</color>
<color name="webViewScrollbarThumbColor">#FFABABAB</color>

Copy link
Contributor

@subsymbolic subsymbolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@CDRussell CDRussell merged commit c480449 into develop Feb 7, 2018
@CDRussell CDRussell deleted the feature/show_scrollbars_in_webview branch February 7, 2018 14:12
@CDRussell CDRussell restored the feature/show_scrollbars_in_webview branch February 7, 2018 16:41
@CDRussell CDRussell deleted the feature/show_scrollbars_in_webview branch February 7, 2018 16:43
aitorvs pushed a commit that referenced this pull request Nov 18, 2021
* Add a new log statement to help debugging

* Fix logging format

Co-authored-by: Craig Russell <CDRussell@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants