Fix landscape layout's squished controls; add scroll view to menu items #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@CDRussell on which device was this happening? I'm not seeing it on my Pixel 2 XL. I would like to reproduce the issue so I can confirm that it is fixed. |
Member
Author
|
I was seeing it on the Samsung Galaxy S6. I'll confirm I can still reproduce the problem on |
Member
Author
|
@subsymbolic , the problem only manifests itself after a menu item containing a checkbox is added, which is what is happening as part of #198 So i'd suggest getting #198 merged first, and the problem should be reproducible. This PR will need a minor merge conflict resolved, but just a small one; after that it should be testable that this will fix the now-visible problem. |
Member
Author
|
Screenshot of the problem |
subsymbolic
approved these changes
Feb 23, 2018
aitorvs
pushed a commit
that referenced
this pull request
Nov 18, 2021
* Implement the Report and Issue screen * Mods due to non-transitive R files * Review: remove findViewById as we use view binding * Review: remove commented out code * Review: remove the refreshTickerChannel and use a better way * Report an Issue screen - Native form screens [2/n] (#199) * Implement the Report and Issue form screens * Fix tests * Review: call sendAppBreakageReport from the ReportBreakageTextFormActivity instead * Review: remove the lateinit var adapter * Review: use Snackbar.LENGTH_LONG instead * Review: fix copy Where -> Were * Report an Issue screen - Add VPN metadata to breakage pixel [3/3] (#201) * Attach vpn metadata to breakage pixel * FIX: Add scroll view to the breakage single choice screen * Review: Use NestedScrollView instead of ScrollView * Review: Fix the letterSpacing for body1 and Body2 styles * App breakage design review (#204) * FIX: Add scroll view to the breakage single choice screen * FIX: Items on Report an issue page are not tappable * FIX: Make input field optional * FIX: Incorrect font weight on titles * FIX: Allow multiple lines in radio button labels * FIX: The this form link on Report an issue * Address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Issue URL: https://app.asana.com/0/488551667048375/567110983215934
Description
Add scroll view to popup menu, and fix the horizontal squishing that happens to the back/forward/refresh controls on landscape.
Steps to Test this PR:
popup_window_browser_menu.xml