Add flag so that users' typed text isn't used for personalisation #217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Task/Issue URL: https://app.asana.com/0/search/587554197702895/567594137922103
Tech Design URL:
CC:
Description:
By default, any text the user types into the app can be used for personalisation by whichever keyboard is in use.
This PR will add the non-personalisation flag to request that doesn't happen for text typed in our app. Note, this isn't a guarantee and is just a request; the keyboard app can do whatever it wants still.
There are two places to apply the flag; one is on the omnibar
EditTextas that is a native component, and another is for keyboards spawned through theWebView.The flag is only applicable for devices running Oreo and upwards.
Discussion
Do you think this needs to be a user-preference? It feels safe enough to me to always have it enabled.
Steps to test this PR:
WebViewitself and ensure you see the same incognito watermark.Internal references:
Software Engineering Expectations
Technical Design Template