Skip to content

Conversation

@CDRussell
Copy link
Member

@CDRussell CDRussell commented Mar 9, 2018

Task/Issue URL: https://app.asana.com/0/search/587554197702895/567594137922103
Tech Design URL:
CC:

Description:
By default, any text the user types into the app can be used for personalisation by whichever keyboard is in use.

This PR will add the non-personalisation flag to request that doesn't happen for text typed in our app. Note, this isn't a guarantee and is just a request; the keyboard app can do whatever it wants still.

There are two places to apply the flag; one is on the omnibar EditText as that is a native component, and another is for keyboards spawned through the WebView.

The flag is only applicable for devices running Oreo and upwards.

Discussion
Do you think this needs to be a user-preference? It feels safe enough to me to always have it enabled.

Steps to test this PR:

  1. Launch the app
  2. Click on the omnibar
  3. If using standard Android GBoard, ensure you are in keyboard incognito mode. This can be verified by the very faint spy watermark.
  4. If using another keyboard, then it probably isn't respected anyway, so you're unlikely to notice any change.
  5. Load a webpage, like our SERP, and start typing content INSIDE the WebView itself and ensure you see the same incognito watermark.

Internal references:

Software Engineering Expectations
Technical Design Template

@CDRussell CDRussell requested review from brindy and subsymbolic March 9, 2018 11:40
@CDRussell
Copy link
Member Author

screenshot_20180309-114106

Example of incognito watermark

Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@subsymbolic subsymbolic merged commit 4c26bc6 into develop Mar 14, 2018
@subsymbolic subsymbolic deleted the feature/no_personalised_keyboard_learning branch March 14, 2018 19:11
aitorvs pushed a commit that referenced this pull request Nov 18, 2021
* when the user skips reporting we still want to disable the app protection for that specific app

* fixed test compilation issues

* spotless reference

Co-authored-by: David González <malmstein@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants