Use alt DDG logo when height is prohibitively small to use main one #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…landscape_ddg_logo
subsymbolic
approved these changes
Mar 16, 2018
Contributor
subsymbolic
left a comment
subsymbolic
left a comment
There was a problem hiding this comment.
Look incredible. Great wok.
aitorvs
pushed a commit
that referenced
this pull request
Nov 18, 2021
* Remove Firebase * Remove unused code * Revert "waitlist is always bypassed, until we actually need it (#214)" This reverts commit 54b14b5. * FIX: remove usage of missing Command.LaunchAppTPOnboarding * FIX AppTP waitlist-onboarding flow for production build * fixup! FIX AppTP waitlist-onboarding flow for production build * Ensure onboarding is showed next time around after X out (#227) * Ensure onboarding is showed next time around after X out * Hardcode shared prefs name rather than class name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/547792610048271/595184799738126
Tech Design URL:
CC:
Description:
Shows alternative logo when the screen height isn't large enough to comfortably show the original logo. Doesn't care about portrait/landscape - only looking at height.
Steps to test this PR:
Internal references:
Software Engineering Expectations
Technical Design Template