Add feedback and broken site form to android #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brindy
reviewed
Jun 20, 2018
app/src/main/res/values/strings.xml
Outdated
| <string name="feedbackModalDescription">Anonymously share your feedback to help us improve the DuckDuckGo Privacy Browser</string> | ||
| <string name="feedbackReportBrokenSite">Report a broken site</string> | ||
| <string name="feedbackDomainAdded">Domain Added to Feedback Report</string> | ||
| <string name="feedbackUrlHint">Enter url</string> |
Contributor
There was a problem hiding this comment.
super-picky, but should URL be in uppercase?
brindy
approved these changes
Jun 20, 2018
Contributor
brindy
left a comment
brindy
left a comment
There was a problem hiding this comment.
Tested it and it worked. Code LGTM - just a couple of minor picky comments :)
| } | ||
|
|
||
| val viewState: MutableLiveData<ViewState> = MutableLiveData() | ||
| private val viewValue: ViewState get() = viewState.value!! |
Contributor
There was a problem hiding this comment.
This is a personal thing, but I tend to group variables with similar access modifiers together, with private nearer to the constructor, if there is one. I don't know if there's a convention for this in Kotlin though?
Contributor
Author
|
@brindy I made some small final copy and layout changes, feel free to rereview. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/361428290920652/688515420618259
Tech Design URL: N/A
Description:
Add a native feedback form for general and broken sites feedback.
Note: the UI uses native text fields, I will be validating that with design and expect to do a final pass to polish.
Steps to test this PR:
TEST 1: Broken site:
TEST 2: Broken site validation:
Note: we only do basic "empty" validation here (the same as extensions) as a user may just want to enter text e.g "facebook"
TEST 3: Feedback Message:
Internal references:
Software Engineering Expectations
Technical Design Template