Feature/home screen call to action #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add_to_home_screen # Conflicts: # app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt # app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt # app/src/main/java/com/duckduckgo/app/global/ViewModelFactory.kt
These have slightly different requirements in terms of their scroll-observing behaviours. We do want the browser layout mode to respect the toolbar scrolling for instance, but we don't want the same behaviour for the new tab view. Trying to use the same `app:layout_behavior="@string/appbar_scrolling_view_behavior"` behaviour in both modes means that the new tab layout is essentially forced off screen vertically and it makes it difficult to add a button that anchors to the bottom. Splitting these into two distinct modes lets us better control both modes without trying to find one set of views and flags which works well enough for both.
…add_to_home_screen
…add_to_home_screen
Contributor
|
On my One Plus One (Android 5.1.1), there's a faint flicker of the CTA just as the keyboard comes up. Edit: I also see this on Nougat+ when the variant is such that the CTA shouldn't be seen. Edit: Setting android:visibility="invisible" in the CTA container layout seems to fix it. |
Contributor
|
After clicking on "Go to Settings" and making DDG the Browser App, I then hit back to get back to the app CTA is not visible as expected, but the logo is missing.
Pixel 2 API 27 emulator. |
brindy
reviewed
Jul 17, 2018
Contributor
brindy
left a comment
brindy
left a comment
There was a problem hiding this comment.
Generally looks good apart from a couple of buggettes. :)
brindy
approved these changes
Jul 19, 2018
Contributor
brindy
left a comment
brindy
left a comment
There was a problem hiding this comment.
Bug seems fixed and I saw each of the variants. LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/715540186137137
Tech Design URL:
CC:
Description:
Adds a new variant for informing users they can add the DDG app as their default browser.
This time, it's a call to action on the new tab screen.
Steps to test this PR:
Nougat or newer
VariantManager)Xbutton; verify the button is no longer visibleMarshmallow or earlier
key=""since we don't support these variants on pre-Nougat devicesInternal references:
Software Engineering Expectations
Technical Design Template