Use stored specification rather than etag download check for https binary #326
+15
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subsymbolic
changed the title
CDRussell
approved these changes
Aug 16, 2018
| val bytes = response.body()!!.bytes() | ||
| if (!binaryDataStore.verifyCheckSum(bytes, specification.sha256)) { | ||
| throw IOException("Https binary has incorrect checksum, throwisng away file") | ||
| throw IOException("Https binary has incorrect checksum, throwing away file") |
Member
There was a problem hiding this comment.
😃that was the one i couldn't remember! Yas!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/721626625236432
Tech Design URL: N/A
Description:
I noticed the https binary being downloaded at times when it should have come from the cache. This PR replaces the bloom filter download cache check with a check against the stored bloom specification in the db. The bloom filter is a large download and we definitely do not want to duplicate it!
Steps to test this PR:
Internal references:
Software Engineering Expectations
Technical Design Template