Release JNI string chars after use #327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subsymbolic
referenced
this pull request
Aug 15, 2018
* Remove old https solution and replace with large-scale https with bloom filter * Add db migration including deletion of old records * Move 3rd party libs into correct folder * Add transaction for full db updates (where we delete then insert new records) of https whitelist and tracker entries * Make queries more case consistent across * Increase architecture components to 1.1.1. This fixes room migration bug. See May 16 2018 release notes (1.1.1 is identical to 1.1.1-rc1) https://developer.android.com/jetpack/docs/release-notes * Update gradle tooling * Update BitRise config to include avd version
CDRussell
approved these changes
Aug 16, 2018
Member
CDRussell
left a comment
CDRussell
left a comment
There was a problem hiding this comment.
Approving, with the usual caveat that I don't know C++ 😰
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/721626625236432
Description:
JNI cleanup to release chars after use
Steps to test this PR:
Internal references:
Software Engineering Expectations
Technical Design Template