Feature/fire button visited sites fix #332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires a few tweaks along the way, mainly around nullability of variables
# Conflicts: # app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt # build.gradle
brindy
reviewed
Aug 24, 2018
Contributor
brindy
left a comment
brindy
left a comment
There was a problem hiding this comment.
Looks good! Couple of minor comments...
| companion object { | ||
| private const val KEY_RESTART_INTENTS = "KEY_RESTART_INTENTS" | ||
|
|
||
| fun triggerRebirth(context: Context) { |
Contributor
There was a problem hiding this comment.
sounds messy :) how about triggerRestart ?
| configureDependencyInjection() | ||
|
|
||
| if(appIsRestarting()) return | ||
|
|
|
|
||
|
|
||
| abstract class LottieAnimationListener : Animator.AnimatorListener { | ||
|
|
Contributor
There was a problem hiding this comment.
Can be deleted if you use https://developer.android.com/reference/android/animation/AnimatorListenerAdapter
| if (savedInstanceState == null) { | ||
|
|
||
| fireAnimationView.addAnimatorListener(object : LottieAnimationListener() { | ||
| override fun onAnimationStart(p0: Animator?) { |
Contributor
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/749739069164807
Tech Design URL:
CC:
Description:
Workaround for the
WebViewbug where visited links were rendered a different colour, even after the history was cleared.WebViewbug report: https://bugs.chromium.org/p/chromium/issues/detail?id=709627Steps to test this PR:
Repeat the steps above, but with some tougher scenarios for the FireActivity; rotate it, hit the home and return to the app etc...
Internal references:
Software Engineering Expectations
Technical Design Template