Skip to content

Conversation

@CDRussell
Copy link
Member

Task/Issue URL: https://app.asana.com/0/72649045549333/804357446611984
Tech Design URL:
CC:

Description:
Removing variants which are no longer active.

Steps to test this PR:

  1. Migrate from existing active variant; verify you are migrated to default "" variant key (filter logcat for user will now use default variant)
  2. Ensure none of the experimental features are visible to you
    1. home screen call to actions (neither of them)
    2. timed banner above WebView (would show only after 20s on DEBUG builds)

Internal references:

Software Engineering Expectations
Technical Design Template

@brindy brindy self-assigned this Sep 3, 2018
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

# Conflicts:
#	app/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt
@CDRussell CDRussell merged commit 4396167 into develop Sep 3, 2018
@CDRussell CDRussell deleted the feature/remove_closed_experiments branch September 3, 2018 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants