Skip to content

Conversation

@subsymbolic
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/361428290920652/816426578517930
Tech Design URL: https://app.asana.com/0/361428290920652/814618797160182

Description:
Adds pixel for settings and switching between light and dark theme

Steps to test this PR:

  1. Comment out all variants other than mh and mj in VariantManager
  2. Install the app
  3. Open Settings note that the mp pixel fires
  4. Toggle the theme a few times and note that the mp_tl (light theme) and mp td (dark theme) fire as appropriate

Internal references:

Software Engineering Expectations
Technical Design Template

@subsymbolic subsymbolic requested a review from CDRussell October 5, 2018 12:39
@subsymbolic subsymbolic requested a review from brindy October 5, 2018 14:14
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - something to consider though is that there are other things on the settings screen. You might see a lot of "open settings" pixels and if you don't see many of the toggle light/dark theme ones it might be the user is going to settings for something else. Ideally you'd add a pixel to everything so that you can apportion the opening of the settings with toggling (and everything else), otherwise it's going to be pretty meaningless when looking at the data.

@subsymbolic
Copy link
Contributor Author

subsymbolic commented Oct 9, 2018

At this stage we want to know if users ever open settings so that we can work out if the toggle is in a discoverable enough place, I'm sure we'll add more pixels later. In terms of light / dark toggle the value selected will be compared to each other to see if users are more likely to switch to light or dark (half users were set to light and the other to dark by default)

@subsymbolic subsymbolic merged commit e8210d9 into develop Oct 9, 2018
@subsymbolic subsymbolic deleted the feature/light_theme_pixel branch October 9, 2018 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants