-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Light theme polish #375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Light theme polish #375
Conversation
brindy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - the status bar is dark when switching from light to dark, but that seems to only be problem on a small number of emulators/devices.
|
Hold off merging - the overflow menu on the bookmarks screen is black text on dark background. Tried it on an API 23 and API 27 emulator... |
|
Good catch, I have updated the overflow menu color. Thanks for the review @brindy. |
brindy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Task/Issue URL: https://app.asana.com/0/361428290920652/832439960662903
Description:
Light theme polish
Steps to test this PR:
NOTE: it may be helpful to comment out the
sa,sbandmgvariants inVariantManager.kt.Light theme tweaks:
Ensure omnibar does not disappear
Internal references:
Software Engineering Expectations
Technical Design Template