Skip to content

Conversation

@subsymbolic
Copy link
Contributor

@subsymbolic subsymbolic commented Oct 30, 2018

Task/Issue URL: https://app.asana.com/0/inbox/361428290920650/816830036286389/889504268656433
Tech Design URL: N/A

Description:
Remove the light theme A/B experiment and release the light theme as a settings option, maintaining the dark theme default.

Steps to test this PR:
Upgrade installation

  1. Install the develop versions of the app, ensuring that you are allocated to varianr mj
  2. Go to settings and switch to light theme
  3. Now install this branch over the top
  4. Ensure your light theme selection was maintained

New installation

  1. Install a fresh version of the app
  2. Ensure that the dark theme is the default
  3. Ensure the theme can be changed to light in settings

Internal references:

Software Engineering Expectations
Technical Design Template

@subsymbolic subsymbolic requested a review from CDRussell October 30, 2018 19:18
@CDRussell CDRussell self-assigned this Oct 31, 2018
@subsymbolic subsymbolic merged commit 161dbad into develop Oct 31, 2018
@subsymbolic subsymbolic deleted the feature/enable_light_theme_option branch October 31, 2018 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants