Skip to content

Conversation

@aitorvs
Copy link
Collaborator

@aitorvs aitorvs commented Jun 29, 2024

Task/Issue URL: https://app.asana.com/0/1202552961248957/1207692081807518/f

Description

Remove the warning on custom DNS screen when private DNS is set to automatic

Steps to test this PR

Test automatic mode

  • install from this branch
  • ensure private DNS is set to off
  • enable VPN and set VPN custom DNS to 1.1.1.1
  • verify custom DNS is correctly enabled
  • go android settings -> private DNS and set to dns.google
  • back to DDG app -> VPN custom DNS screen
  • verify warning "private DNS is already specified...turn off private DNS..." shows
  • verify internet connection works
  • verify DNS traffic is routed through Google (dnsleaktest.com)
  • go android settings -> private DNS and set to automatic
  • back to DDG app, VPN custom DNS screen
  • verify warning "private DNS is already specified...turn off private DNS..." does NOT show
  • verify internet connection works
  • verify DNS traffic is routed through Cloudflare (dnsleaktest.com)

Copy link
Collaborator Author

aitorvs commented Jun 29, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @aitorvs and the rest of your teammates on Graphite Graphite

@aitorvs aitorvs force-pushed the fix/aitor/vpn/custom_dns branch from 6654417 to 5ae89a0 Compare June 29, 2024 21:15
@karlenDimla karlenDimla merged commit d2d7b55 into develop Jul 1, 2024
@karlenDimla karlenDimla deleted the fix/aitor/vpn/custom_dns branch July 1, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants