Ensure RMF is not shown on app start if browser showing #4753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @malmstein and the rest of your teammates on |
anikiki
reviewed
Jul 11, 2024
| ) : MainProcessLifecycleObserver { | ||
|
|
||
| override fun onCreate(owner: LifecycleOwner) { | ||
| override fun onStart(owner: LifecycleOwner) { |
Contributor
There was a problem hiding this comment.
Any reason for this change?
Contributor
There was a problem hiding this comment.
No, leftover from testing
cmonfortep
approved these changes
Jul 11, 2024
Contributor
cmonfortep
left a comment
cmonfortep
left a comment
There was a problem hiding this comment.
LGTM tested and haven't found anything broken.
Just left a minor comment about hiding the container for ssl errors.
| ) { | ||
| webViewContainer.gone() | ||
| newBrowserTab.newTabLayout.gone() | ||
| newBrowserTab.newTabContainerLayout.gone() |
Contributor
There was a problem hiding this comment.
Edge case landing here during onboarding, but this can be removed based on what we saw during testing
Contributor
There was a problem hiding this comment.
scratch that, it's correct to set newtab gone here.
malmstein
deleted the
feature/david/07-11-ensure_rmf_is_not_shown_on_app_start_if_browser_showing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1157893581871903/1207786103010682
Description
Steps to test this PR
RMF