Delay adding FocusedView until it's necessary #4772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @malmstein and the rest of your teammates on |
malmstein
deleted the
feature/david/07-17-delay_adding_focusedview_until_it_s_necessary
branch
Contributor
Author
|
Thanks @anikiki ! |
anikiki
pushed a commit
that referenced
this pull request
Jul 17, 2024
Task/Issue URL: https://app.asana.com/0/1157893581871903/1207816154536989/f ### Description Delay the addition of the FocusedView until it’s necessary ### Steps to test this PR _Enable FocusedView_ - [x] Fresh install, add some favourites - [x] Visit a site so it’s setup for the next time the app opens - [x] Force close and open it up again - [x] Tap on the omnibar - [x] Verify that FocusedView is visible - [x] Open New Tab - [x] Visit a site - [x] Tap on the omnibar - [x] Verify FocusedView is visible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1157893581871903/1207816154536989/f
Description
Delay the addition of the FocusedView until it’s necessary
Steps to test this PR
Enable FocusedView