Skip to content

Conversation

@nalcalag
Copy link
Contributor

@nalcalag nalcalag commented Jul 18, 2024

Task/Issue URL: https://app.asana.com/0/488551667048375/1207845944313951/f

Description

Fix for not showing favorites displayed underneath the 'visit site' Dax dialog

Steps to test this PR

On each step, wait for searches and sites to fully load in the browser

  • Fresh install
  • Perform a search
  • Save bookmark → Add favorite
  • Visit a site → ⚠️ Don't dismiss the trackers onboarding CTA
  • Save bookmark → Add favorite
  • Open a new tab
  • Perform a search
  • Open a new tab
  • Check favorites are not displayed underneath Dax dialog
  • Tap on a site suggestion
  • Check favorites are not displayed underneath Dax dialog before site is loaded

UI changes

Before After
Screenshot_20240718_140440 Screenshot 2024-07-19 at 12 37 48

@nalcalag
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @nalcalag and the rest of your teammates on Graphite Graphite

@nalcalag nalcalag marked this pull request as ready for review July 19, 2024 10:39
Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nalcalag nalcalag merged commit f777c5c into develop Jul 19, 2024
@nalcalag nalcalag deleted the feature/noelia/favorites_displayed_underneath_dax_dialog branch July 19, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants