Add ATB initialized callback to ATB plugin, and rename for clarity #4850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 2, 2024
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @CDRussell and the rest of your teammates on |
CDRussell
force-pushed
the
feature/craig/add_atb_initialized_callback
branch
from
429fe2b to
3fab8ee
Compare
CDRussell
force-pushed
the
feature/craig/add_atb_initialized_callback
branch
from
3fab8ee to
f149279
Compare
CDRussell
force-pushed
the
feature/craig/add_atb_initialized_callback
branch
from
f149279 to
847d50b
Compare
CDRussell
changed the base branch from
feature/craig/ad_campaign_referrer_extraction
to
develop
malmstein
approved these changes
Aug 5, 2024
Contributor
malmstein
left a comment
malmstein
left a comment
There was a problem hiding this comment.
Nice work @CDRussell !
Member
Author
Merge activity
|
karlenDimla
pushed a commit
that referenced
this pull request
Aug 6, 2024
…4850) Task/Issue URL: https://app.asana.com/0/0/1207965428441026/f ### Description - Renames `RefreshRetentionAtbPlugin` ➡️ `AtbLifecyclePlugin` - Adds atb initialized callback - Makes default implementation of the callbacks no-ops No other changes in this PR. ### Steps to test this PR - [ ] QA-optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1207965428441026/f
Description
RefreshRetentionAtbPlugin➡️AtbLifecyclePluginNo other changes in this PR.
Steps to test this PR