Tab manager crash fix #4865
Merged
Tab manager crash fix #4865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlenDimla
pushed a commit
that referenced
this pull request
Aug 6, 2024
Task/Issue URL: https://app.asana.com/0/1202552961248957/1207981775109546/f Possibly also: https://app.asana.com/0/1202552961248957/1207981775109549 ### Description This PR adds bounds checks for the tab getter in the RecyclerView adapter. The first crash is caused by a rapid double tap on the tab close button, which results in an invalid index being returned. The second crash is possibly a different manifestation of the same problem but due to a race condition it happens elsewhere. It should be resolved by [8bfcfbd](8bfcfbd). ### Steps to test this PR _Duble tap_ - [x] Go to the tab manager - [x] Add a few tabs - [x] Tap on a tab close button very quickly - [x] Notice the app doesn’t crash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1202552961248957/1207981775109546/f
Possibly also: https://app.asana.com/0/1202552961248957/1207981775109549
Description
This PR adds bounds checks for the tab getter in the RecyclerView adapter. The first crash is caused by a rapid double tap on the tab close button, which results in an invalid index being returned.
The second crash is possibly a different manifestation of the same problem but due to a race condition it happens elsewhere. It should be resolved by 8bfcfbd.
Steps to test this PR
Duble tap