Fix splashscreen not showing <= API 30 #4889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @mikescamell and the rest of your teammates on |
The compat library will take care of this for us so we put everything in the root values files which is the next commit.
As we're not inheriting from any theme we'll need to set the colors for the status bar and navigation bar in the splash style. I'm using what I found on the light and dark themes.
We need to install before super.onCreate is called as per docs. As we use the LaunchBridgeActivity for routing it's best we call setKeepOnScreenCondition which keeps this activity but stops it from rendering.
mikescamell
force-pushed
the
fix/mike/splash-screen-logo-missing-on-lower-api-levels
branch
from
0986174 to
0b92a5e
Compare
mikescamell
changed the title
anikiki
reviewed
Aug 14, 2024
Contributor
anikiki
left a comment
anikiki
left a comment
There was a problem hiding this comment.
Looks good and works as expected! 🎉
anikiki
approved these changes
Aug 15, 2024
mikescamell
deleted the
fix/mike/splash-screen-logo-missing-on-lower-api-levels
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207908166761516/1206826738295232/f
Description
The splashscreen was not showing on devices on devices <= API 30.
To fix this I used the spashscreen-compat library and removed the need for dedicated splashscreen styles on API 31+ as the compat library will take of that for us.
The splashscreen is very quick on a warm start on <= API 30 (see the demos) but I don’t think it’s worth adding any kind of artificial delay to show it for a longer period.
Steps to test this PR
If you have a device that’s <= API 31 to test then please do! Unfortunately I do not have a device on hand at that API level.
UI changes
API 26 before shown as a demo for all devices < 30
I’ve provided some before videos on actual devices on >= API 30
api26before.mp4
api26.webm
api27.webm
api28.webm
api29.webm
oneplus-api30-before.mp4
oneplus-api30.mp4
pixel3_api31_before.mp4
pixel3-api31.mp4
api32.webm
pixel4a_api33_before.mp4
pixel4a-api33.mp4
pixel8pro_api34_before.mp4
pixel8pro_api34_after.mp4
api35.webm