Skip to content

Feature/remove tracker blocker opt in experiment #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2019
Merged

Feature/remove tracker blocker opt in experiment #493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f65fab
Code tidy
CDRussell May 27, 2019
871eff4
Remove experimental variant for tracker blocker opt-in
CDRussell May 27, 2019
69a4b18
Restore tracker blocker opt-in experiments with 0-weighting
CDRussell May 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions app/src/main/java/com/duckduckgo/app/onboarding/ui/OnboardingViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ class OnboardingViewModel(
fun onOnboardingDone() {
onboardingStore.onboardingShown()
fireTrackerBlockingFinalStatePixel()

}

private fun fireTrackerBlockingFinalStatePixel() {
Expand All @@ -59,4 +58,4 @@ class OnboardingViewModel(
pixel.fire(pixelName)
}
}
}
}
5 changes: 3 additions & 2 deletions app/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ interface VariantManager {
Variant(key = "mk", weight = 0.0, features = listOf(NotificationPrivacyDay1)),

// tracker blocker opt in variants
Variant(key = "mm", weight = 1.0, features = emptyList()),
Variant(key = "mn", weight = 1.0, features = listOf(TrackerBlockingOnboardingOptIn))
Variant(key = "mm", weight = 0.0, features = emptyList()),
Variant(key = "mn", weight = 0.0, features = listOf(TrackerBlockingOnboardingOptIn))
)
}

Expand Down Expand Up @@ -104,6 +104,7 @@ class ExperimentationVariantManager(
private fun generateVariant(activeVariants: List<Variant>): Variant {
val weightSum = activeVariants.sumByDouble { it.weight }
if (weightSum == 0.0) {
Timber.v("No variants active; allocating default")
return DEFAULT_VARIANT
}
val randomizedIndex = indexRandomizer.random(activeVariants)
Expand Down