Skip to content

Conversation

@CDRussell
Copy link
Member

Task/Issue URL: https://app.asana.com/0/414730916066338/1127121283487017
Tech Design URL:
CC:

Description:
Clears the app cache when the fire button is invoked.

Steps to test this PR:

  1. Ensure you can verify app data (e.g., use an emulator / rooted device)
  2. Do a DDG search
  3. Clear the data using the fire button
  4. Examine the data/data/com.duckduckgo.mobile.android/cache directory and verify there are no remnants of the previous search.

Internal references:

Software Engineering Expectations
Technical Design Template

@CDRussell CDRussell requested a review from subsymbolic as a code owner June 14, 2019 14:27
Copy link
Contributor

@subsymbolic subsymbolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@subsymbolic subsymbolic merged commit 55c1e42 into develop Jun 14, 2019
@subsymbolic subsymbolic deleted the feature/clear_app_cache_on_data_clear branch June 14, 2019 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants