Skip to content

Use counts in leaderboard #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 14, 2019
Merged

Use counts in leaderboard #509

merged 2 commits into from
Jun 14, 2019

Conversation

@subsymbolic
Copy link
Contributor

@subsymbolic subsymbolic commented Jun 14, 2019 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/361428290920652/1127123170200348

Description:
Switches to counts in the tracker leaderboard

Steps to test this PR:

Test migration and new data:

  1. Switch to develop branch
  2. UpdatePrivacyDashboardViewModel.kt variable LEADERBOARD_MIN_DOMAINS_EXCLUSIVE to 3
  3. Run the app, visit a few pages and make sure the tracker leaderboard is showing
  4. Switch to this branch
  5. Run the app and ensure the migration succeeds
  6. Visit the privacy dash, the leaderboard should reset
  7. Visit a few pages and make sure the tracker leaderboard shows again

Check updated database:

  1. Download the app.db database from app storage
  2. Check the network_leaderboard table and ensure network entries are now counts not strings
  3. Check the sites_visited table and ensure the entries are now counts not strings
Internal references:

Software Engineering Expectations
Technical Design Template

@subsymbolic subsymbolic requested a review from CDRussell as a code owner June 14, 2019 17:17
@subsymbolic subsymbolic merged commit bf7e5d0 into develop Jun 14, 2019
@subsymbolic
Copy link
Contributor Author

subsymbolic commented Jun 14, 2019

@CDRussell as per our conversation earlier, I'm merging this so we can include it in the beta. I would still like a retrospective review.

nilnilnil
nilnilnil reviewed Jun 14, 2019
View reviewed changes
Copy link
Contributor

@nilnilnil nilnilnil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

CDRussell
CDRussell reviewed Jun 16, 2019
View reviewed changes
@CDRussell
Copy link
Member

CDRussell commented Jun 16, 2019

Minor code comments only; tested and all working as expected.

@subsymbolic
Copy link
Contributor Author

subsymbolic commented Jun 16, 2019 •
edited
Loading

Many thanks for the review @CDRussell 🙌
I'll send a new PR for the typos!! 🤪

@subsymbolic subsymbolic mentioned this pull request Jun 18, 2019
Merged
subsymbolic added a commit that referenced this pull request Jun 19, 2019
@subsymbolic
Small typo and method name tweaks (#514)
ec01da2 
* Fix typos in test and variable names
* Rename historic variable as per suggestion in #509
* Be more explicit about test boundaries
@subsymbolic subsymbolic deleted the feature/leaderboard_nondistinct_counts branch June 21, 2019 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nilnilnil nilnilnil nilnilnil left review comments

@CDRussell CDRussell CDRussell left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@subsymbolic @CDRussell @nilnilnil