Rename report flow param from prompt to reload-three-times-within-20-seconds #5339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
lmac012
approved these changes
Dec 3, 2024
Contributor
lmac012
left a comment
lmac012
left a comment
There was a problem hiding this comment.
LGTM, left one question.
| when (params.reportFlow) { | ||
| BrokenSiteForm.BrokenSiteFormReportFlow.MENU -> ReportFlow.MENU | ||
| BrokenSiteForm.BrokenSiteFormReportFlow.PROMPT -> ReportFlow.PROMPT | ||
| BrokenSiteForm.BrokenSiteFormReportFlow.PROMPT -> ReportFlow.RELOAD_THREE_TIMES_WITHIN_20_SECONDS |
Contributor
There was a problem hiding this comment.
Should we also rename BrokenSiteForm.BrokenSiteFormReportFlow.PROMPT?
Contributor
Author
There was a problem hiding this comment.
The only important thing is the string, but still, we should rename this for consistency. Done
CrisBarreiro
force-pushed
the
fix/cris/rename-broken-site-prompt-reportflow-param
branch
from
55bb39e to
15d6f0c
Compare
CrisBarreiro
force-pushed
the
fix/cris/rename-broken-site-prompt-reportflow-param
branch
from
15d6f0c to
71f7438
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1208889990660025/f
Description
Align reportFlow value with the spec. reportFlow -> reload-three-times-within-20-seconds
Steps to test this PR
n/a
UI changes
n/a