Allow scrolling all of the password management list mode screen #5377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CDRussell
deleted the
feature/craig/make_all_password_management_screen_scrollable
branch
3 tasks
CDRussell
added a commit
that referenced
this pull request
Jan 8, 2025
…en" (#5445) Task/Issue URL: https://app.asana.com/0/608920331025315/1209106756565265/f ### Description Reverts changes made in #5377 as it introduces performance issues on the password management screen with larger password list sizes. Depending on the device / list size, it can be crippling performance. ### Steps to test this PR - [x] install `internal` variant to make the next step easier - [x] Add 500+ passwords (can be done in `Autofill Dev Settings` screen, using the **Add a lot of sample logins** button) - [x] Visit password management screen and verify there isn’t a huge delay in rendering the password list For contrast, if you try this on `develop` you will notice a large perf issue. Co-authored-by: Craig Russell <1336281+CDRussell@users.noreply.github.com>
karlenDimla
pushed a commit
that referenced
this pull request
Jan 8, 2025
…en" (#5445) Task/Issue URL: https://app.asana.com/0/608920331025315/1209106756565265/f ### Description Reverts changes made in #5377 as it introduces performance issues on the password management screen with larger password list sizes. Depending on the device / list size, it can be crippling performance. ### Steps to test this PR - [x] install `internal` variant to make the next step easier - [x] Add 500+ passwords (can be done in `Autofill Dev Settings` screen, using the **Add a lot of sample logins** button) - [x] Visit password management screen and verify there isn’t a huge delay in rendering the password list For contrast, if you try this on `develop` you will notice a large perf issue. Co-authored-by: Craig Russell <1336281+CDRussell@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/488551667048375/1208758825735780/f
Description
This PR tweaks the layout params for the password recycler view so that the whole view content, already encapsulated in a
NestedScrollView, is scrollable.Steps to test this PR
Screenshots
Current behavior
### New behavior
