Onboarding: Dismiss contextual onboarding dialogs after 1 view #5747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalcalag
force-pushed
the
feature/noelia/dismiss_context_dialogs_after_shown
branch
from
d1c7b7d to
d79f3b3
Compare
mikescamell
approved these changes
Mar 14, 2025
Contributor
mikescamell
left a comment
mikescamell
left a comment
There was a problem hiding this comment.
LGTM! 
Only a couple of comments
joshliebe
pushed a commit
that referenced
this pull request
Mar 19, 2025
Task/Issue URL: https://app.asana.com/0/1176956903599313/1209163229346625 ### Description Show context onboarding Dax dialogs when they are shown ### Steps to test this PR _Opening a New Tab_ - [x] Fresh install - [x] When browser is shown, 'Try a search' onboarding dialog will appear - [x] Open a new tab - [x] Check dialog is replaced for 'Visit a site' dialog - [x] Open a new tab - [x] Check dialog is replaced for 'End' dialog _Visit a site dialog not appearing twice_ - [x] Fresh install - [x] When browser is shown, 'Try a search' onboarding dialog will appear - [x] Visit a site without opening a new tab - [x] Open a new tab - [x] Check 'Visit a site' dialog is not shown - [x] Check 'End' dialog is shown _Close and open the app again_ - [x] Fresh install - [x] When browser is shown, 'Try a search' onboarding dialog will appear - [x] Background or close the app - [x] Open it again - [x] Check dialog is replaced for 'Visit a site' dialog - [x] Close or background the app - [x] Open it again - [x] Check dialog is replaced for 'End' dialog ### No UI changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1176956903599313/1209163229346625
Description
Show context onboarding Dax dialogs when they are shown
Steps to test this PR
Opening a New Tab
Visit a site dialog not appearing twice
Close and open the app again
No UI changes