Skip to content

Conversation

@malmstein
Copy link
Contributor

@malmstein malmstein commented Oct 23, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/1157893581871903/task/1211730035278177?focus=true

Description

Fix JS injection for text selector in Duck.ai

Steps to test this PR

First open

  • Fresh install, open Duck.ai without a prompt
  • Verify Terms and Conditions dialog appears
  • Accept them
  • Verify Keyboard doesn’t appear
  • Close Duck.ai (don’t hide the tips, we need them later)

Keyboard doesn’t open when Tips present

  • Open Duck.ai without a prompt
  • Verify keyboard doesn’t open
  • Verify Tips are present
  • Hide the tips
  • Verify keyboard doesn’t appear
  • Close Duck.ai

Keyboard opens when Tips are not present

  • Open Duck.ai without a prompt
  • Verify keyboard opens

Auto prompt

  • Open Duck.ai with a prompt
  • Verify keyboard doesn’t open

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@malmstein malmstein marked this pull request as ready for review October 23, 2025 11:24
Copy link
Contributor

@joshliebe joshliebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM! 🚀

@malmstein malmstein merged commit 42e9ab4 into develop Oct 23, 2025
7 checks passed
@malmstein malmstein deleted the feature/david/10-23-fix_js_selector branch October 23, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants