Webview scaling #70
Merged
Webview scaling #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g partially rendered on screen
karlenDimla
added a commit
that referenced
this pull request
Apr 28, 2023
<!--
Note: This checklist is a reminder of our shared engineering
expectations.
The items in Bold are required
If your PR involves UI changes:
1. Upload screenshots or screencasts that illustrate the changes before
/ after
2. Add them under the UI changes section (feel free to add more columns
if needed)
3. Make sure these changes are tested in API 23 and API 26
If your PR does not involve UI changes, you can remove the **UI
changes** section
-->
Task/Issue URL: https://app.asana.com/0/0/1204192756465933/f
### Description
This PR adds all needed pixels for Netp always-on.
### Steps to test this PR
Optional QA
_Confirm pixels_
- [x] Install build
- [x] Enable different VPN
- [x] Enable NetP
- [x] Verify logcat shows `Pixel sent: m_netp_imp_vpn_conflict_dialog_c`
AND no `Pixel URL request dropped`
- [x] Enable different VPN + enabled always on for that VPN
- [x] Enable NetP
- [x] Verify logcat shows ` Pixel sent:
m_netp_imp_always_on_conflict_dialog_c` AND no `Pixel URL request
dropped`
- [x] Disable different VPN
- [x] Attempt to enable Netp multiple times to show the promotion dialog
- [x] Verify logcat shows `Pixel sent:
m_netp_imp_always_on_promotion_dialog_d
- [x] Click open settings
- [x] Verify logcat shows 'Pixel sent:
m_netp_ev_open_settings_from_always_on_promotion_dialog_c'
- [x] Disable NetP
- [x] Enable always on and lockdown for DDG app
- [x] Enable NetP
- [x] Go out and back to NetP screen
- [x] Verify logcat shows 'Pixel sent:
m_netp_imp_always_on_lockdown_dialog_c'
- [x] Click open settings
- [x] Verify logcat shows 'Pixel sent:
m_netp_ev_open_settings_from_always_on_lockdown_dialog_d'
aitorvs
pushed a commit
that referenced
this pull request
Apr 30, 2023
<!--
Note: This checklist is a reminder of our shared engineering
expectations.
The items in Bold are required
If your PR involves UI changes:
1. Upload screenshots or screencasts that illustrate the changes before
/ after
2. Add them under the UI changes section (feel free to add more columns
if needed)
3. Make sure these changes are tested in API 23 and API 26
If your PR does not involve UI changes, you can remove the **UI
changes** section
-->
Task/Issue URL: https://app.asana.com/0/0/1204192756465933/f
### Description
This PR adds all needed pixels for Netp always-on.
### Steps to test this PR
Optional QA
_Confirm pixels_
- [x] Install build
- [x] Enable different VPN
- [x] Enable NetP
- [x] Verify logcat shows `Pixel sent: m_netp_imp_vpn_conflict_dialog_c`
AND no `Pixel URL request dropped`
- [x] Enable different VPN + enabled always on for that VPN
- [x] Enable NetP
- [x] Verify logcat shows ` Pixel sent:
m_netp_imp_always_on_conflict_dialog_c` AND no `Pixel URL request
dropped`
- [x] Disable different VPN
- [x] Attempt to enable Netp multiple times to show the promotion dialog
- [x] Verify logcat shows `Pixel sent:
m_netp_imp_always_on_promotion_dialog_d
- [x] Click open settings
- [x] Verify logcat shows 'Pixel sent:
m_netp_ev_open_settings_from_always_on_promotion_dialog_c'
- [x] Disable NetP
- [x] Enable always on and lockdown for DDG app
- [x] Enable NetP
- [x] Go out and back to NetP screen
- [x] Verify logcat shows 'Pixel sent:
m_netp_imp_always_on_lockdown_dialog_c'
- [x] Click open settings
- [x] Verify logcat shows 'Pixel sent:
m_netp_ev_open_settings_from_always_on_lockdown_dialog_d'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Issue URL: https://app.asana.com/0/488551667048375/495254191196640
Description
Loads webpages in overview mode, fixing issues where pages were initially too zoomed in and only partially rendered on screen
Steps to Test this PR: