Skip to content

Conversation

@CDRussell
Copy link
Member

@CDRussell CDRussell commented Feb 10, 2020

Task/Issue URL:

Tech Design URL:
CC:

Description:
Captures the eu auction referrer data and maps to a static variant ml if found

Steps to test this PR:

Need to use Play Store ad-hoc app sharing for this. You can either upload your own APK and build your custom URLs to test, or here's some I made earlier! 😃

Device setup

  1. configure logcat to display regex refer|var
  2. Charles interception will be required too.

Scenarios

For each of the scenarios below:

  1. uninstall the app first.
  2. click on the link using your device which launch the ad-hoc Play Store installation screen
  3. install and launch the app
  4. verify if correct referrer identified

No referrer data at all

Campaign referrer

EU auction referrer

Both EU auction referrer and Campaign referrer (shouldn't happen, but if it does, EU auction takes precedence)


Internal references:

Software Engineering Expectations
Technical Design Template

Copy link
Contributor

@subsymbolic subsymbolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work and thanks for providing test builds, made life so much easier. I added one last comment around test names but feel free to merge when you're ready (no rereview needed).

@CDRussell CDRussell merged commit 493a1ea into develop Feb 10, 2020
@CDRussell CDRussell deleted the feature/craig/map_auction_variant branch February 10, 2020 13:41
is EuAuctionReferrerFound -> {
variantManager.updateAppReferrerVariant(VariantManager.RESERVED_EU_AUCTION_VARIANT)
appReferrerDataStore.installedFromEuAuction = true
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it worth adding an else to deal with unexpected referrers?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did wonder about that, too, but decided not to since the else can mean a few different things (no referrer found, there was a problem parsing the referrer etc...) and I can't think of any single thing we'd want to do for each of them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants