-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Feature/craig/map auction variant #710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
app/src/androidTest/java/com/duckduckgo/app/statistics/VariantManagerTest.kt
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/referral/AppInstallationReferrerParser.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/referral/AppInstallationReferrerStateListener.kt
Show resolved
Hide resolved
app/src/androidTest/java/com/duckduckgo/app/referral/QueryParamReferrerParserTest.kt
Outdated
Show resolved
Hide resolved
subsymbolic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work and thanks for providing test builds, made life so much easier. I added one last comment around test names but feel free to merge when you're ready (no rereview needed).
| is EuAuctionReferrerFound -> { | ||
| variantManager.updateAppReferrerVariant(VariantManager.RESERVED_EU_AUCTION_VARIANT) | ||
| appReferrerDataStore.installedFromEuAuction = true | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it worth adding an else to deal with unexpected referrers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did wonder about that, too, but decided not to since the else can mean a few different things (no referrer found, there was a problem parsing the referrer etc...) and I can't think of any single thing we'd want to do for each of them
Task/Issue URL:
Tech Design URL:
CC:
Description:
Captures the eu auction referrer data and maps to a static variant
mlif foundSteps to test this PR:
Need to use Play Store ad-hoc app sharing for this. You can either upload your own APK and build your custom URLs to test, or here's some I made earlier! 😃
Device setup
refer|varScenarios
For each of the scenarios below:
No referrer data at all
/exticall has correct variantt=ddg_androidis added to URL (as normal)Campaign referrer
XXfound (logcat: Updating variant for app referer: XX)/exticall usesXXt=ddg_androidis added to URL (as normal)EU auction referrer
/exticall usesmlt=ddg_androideuis added to URL (instead of normal t=ddg_android)Both EU auction referrer and Campaign referrer (shouldn't happen, but if it does, EU auction takes precedence)
/exticall usesmlt=ddg_androideuis added to URL (instead of normal t=ddg_android)Internal references:
Software Engineering Expectations
Technical Design Template