Skip to content

Remove exception messages from wide events #7113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
+5 −7
Open

Remove exception messages from wide events #7113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...c/test/java/com/duckduckgo/subscriptions/impl/wideevents/AuthTokenRefreshWideEventTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ class AuthTokenRefreshWideEventTest {
metadata = mapOf("play_login_error" to "sign-in-required"),
)
verify(wideEventClient).intervalEnd(16L, "total_duration_ms_bucketed")
verify(wideEventClient).flowFinish(16L, FlowStatus.Failure("IllegalStateException: boom"), emptyMap())
verify(wideEventClient).flowFinish(16L, FlowStatus.Failure("IllegalStateException"), emptyMap())

reset(wideEventClient)

Expand Down Expand Up @@ -230,7 +230,7 @@ class AuthTokenRefreshWideEventTest {
authWideEvent.onFailure(IllegalArgumentException("nope"))

verify(wideEventClient).intervalEnd(19L, "total_duration_ms_bucketed")
verify(wideEventClient).flowFinish(19L, FlowStatus.Failure("IllegalArgumentException: nope"), emptyMap())
verify(wideEventClient).flowFinish(19L, FlowStatus.Failure("IllegalArgumentException"), emptyMap())
}

@SuppressLint("DenyListedApi")
Expand Down
2 changes: 1 addition & 1 deletion ...st/java/com/duckduckgo/subscriptions/impl/wideevents/SubscriptionPurchaseWideEventTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ class SubscriptionPurchaseWideEventTest {
verify(wideEventClient).flowStep(456L, "refresh_subscription", false)
verify(wideEventClient).flowFinish(
wideEventId = 456L,
status = FlowStatus.Failure("IllegalStateException: boom"),
status = FlowStatus.Failure("IllegalStateException"),
metadata = emptyMap(),
)
}
Expand Down
3 changes: 1 addition & 2 deletions ...l/src/main/java/com/duckduckgo/subscriptions/impl/wideevents/AuthTokenRefreshWideEvent.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,5 +191,4 @@ class AuthTokenRefreshWideEventImpl @Inject constructor(
}
}

private fun Exception.toErrorString(): String =
listOfNotNull(javaClass.simpleName, message).joinToString(": ")
private fun Exception.toErrorString(): String = javaClass.simpleName
3 changes: 1 addition & 2 deletions ...c/main/java/com/duckduckgo/subscriptions/impl/wideevents/SubscriptionPurchaseWideEvent.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,5 +337,4 @@ class SubscriptionPurchaseWideEventImpl @Inject constructor(
}
}

private fun Exception.toErrorString(): String =
listOf(javaClass.simpleName, message).joinToString(": ")
private fun Exception.toErrorString(): String = javaClass.simpleName
Loading