Move strings to correct module for bookmark added dialog #7127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 14, 2025
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
CDRussell
force-pushed
the
feature/craig/make_bookmark_added_dialog_less_generic_v3_l10n
branch
2 times, most recently
from
950626b to
cab4cde
Compare
CDRussell
force-pushed
the
feature/craig/make_bookmark_added_dialog_less_generic
branch
from
ca118be to
4ab4dbf
Compare
18 tasks
CDRussell
force-pushed
the
feature/craig/make_bookmark_added_dialog_less_generic
branch
from
4ab4dbf to
9158c48
Compare
CDRussell
force-pushed
the
feature/craig/make_bookmark_added_dialog_less_generic_v3_l10n
branch
from
cab4cde to
3ec24eb
Compare
CrisBarreiro
approved these changes
Nov 18, 2025
CDRussell
force-pushed
the
feature/craig/make_bookmark_added_dialog_less_generic_v3_l10n
branch
from
3ec24eb to
c61a05c
Compare
CDRussell
force-pushed
the
feature/craig/make_bookmark_added_dialog_less_generic
branch
from
9158c48 to
ce58927
Compare
Member
Author
Merge activity
|
CDRussell
changed the base branch from
feature/craig/make_bookmark_added_dialog_less_generic
to
graphite-base/7127
CDRussell
added a commit
that referenced
this pull request
Nov 19, 2025
Task/Issue URL: https://app.asana.com/1/137249556945/project/1208273769335188/task/1211910160515992?focus=true ### Description This is taking `BookmarksBottomSheetDialog`, which is generic but only ever used for a specific use case (bookmark added confirmation) and just making it specific to that use case. This simplifies it as well as better preparing it for extension to support adding an option to let users know they can enable sync. - `BookmarksBottomSheetDialog` --> `BookmarkAddedConfirmationDialog` Strings moving to the correct module is done in #7127 to de-noise this one.. ### Steps to test this PR **Auto-dismisses** - [x] Visit site, tap overflow and choose `Add Bookmark`. - [x] Verify the bookmark added dialog shows and looks the same as prod does - [x] Don't interact with it; verify it auto-dismisses (after ~3.5s) - [x] Choose `Edit Bookmark` and delete it **Edit (not as favorite)** - [x] Choose `Add Bookmark` again, don't toggle the `Add to Favorites` but do tap on `Edit Bookmark`. Verify it isn't marked as favorite. - [x] Delete it **Edit (when a favorite)** - [x] Choose `Add Bookmark` again, this time toggle the `Add to Favorites` to enabled - [x] Tap `Edit Bookmark`. Verify it is still marked as a favorite.
Translate strings-saved-sites to values-de Translate strings-saved-sites to values-sk Translate strings-saved-sites to values-ro Translate strings-saved-sites to values-es Translate strings-saved-sites to values-pl Translate strings-saved-sites to values-lt Translate strings-saved-sites to values-el Translate strings-saved-sites to values-cs Translate strings-saved-sites to values-hr Translate strings-saved-sites to values-fi Translate strings-saved-sites to values-et Translate strings-saved-sites to values-sl Translate strings-saved-sites to values-pt Translate strings-saved-sites to values-fr Translate strings-saved-sites to values-nl Translate strings-saved-sites to values-nb Translate strings-saved-sites to values-it Translate strings-saved-sites to values-sv Translate strings-saved-sites to values-da Translate strings-saved-sites to values-tr Translate strings-saved-sites to values-ru Translate strings-saved-sites to values-bg Translate strings-saved-sites to values-hu
Translate strings-saved-sites to values-de Translate strings-saved-sites to values-sk Translate strings-saved-sites to values-ro Translate strings-saved-sites to values-es Translate strings-saved-sites to values-pl Translate strings-saved-sites to values-lt Translate strings-saved-sites to values-el Translate strings-saved-sites to values-cs Translate strings-saved-sites to values-hr Translate strings-saved-sites to values-fi Translate strings-saved-sites to values-et Translate strings-saved-sites to values-sl Translate strings-saved-sites to values-pt Translate strings-saved-sites to values-fr Translate strings-saved-sites to values-nl Translate strings-saved-sites to values-nb Translate strings-saved-sites to values-it Translate strings-saved-sites to values-sv Translate strings-saved-sites to values-da Translate strings-saved-sites to values-tr Translate strings-saved-sites to values-ru Translate strings-saved-sites to values-bg Translate strings-saved-sites to values-hu
CDRussell
force-pushed
the
feature/craig/make_bookmark_added_dialog_less_generic_v3_l10n
branch
from
c61a05c to
3c6d6fb
Compare
CDRussell
deleted the
feature/craig/make_bookmark_added_dialog_less_generic_v3_l10n
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1208273769335188/task/1211950205463651?focus=true
Description
Moves the strings used in the "bookmark added" dialog to the correct module (
app). Before, the strings lived inside thesaved-sites-implmodule but theappwas reaching into thatimplmodule for its strings.Steps to test this PR