Skip to content

Conversation

@catalinradoiu
Copy link
Contributor

@catalinradoiu catalinradoiu commented Nov 17, 2025

Task/Issue URL:
https://app.asana.com/1/137249556945/project/1211724162604201/task/1211850430148973?focus=true

Description

Added a new toggle handleAboutBlank() to the AndroidBrowserConfigFeature interface. This toggle is internally always enabled and defaults to false. It will be used to determine whether the app should handle "about:blank" URLs based on remote configuration.

Steps to test this PR

Handle About Blank Feature

  • Verify that the new toggle is properly annotated with @Toggle.InternalAlwaysEnabled
  • Verify that the toggle defaults to false when remote config is not present

UI changes

No UI or functional changes in this PR.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@catalinradoiu catalinradoiu marked this pull request as ready for review November 17, 2025 16:04
@anikiki anikiki self-assigned this Nov 17, 2025
Copy link
Contributor

@anikiki anikiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@catalinradoiu catalinradoiu merged commit fb2396f into develop Nov 17, 2025
20 of 21 checks passed
@catalinradoiu catalinradoiu deleted the fix/cradoiu/about-blank-feature-flag branch November 17, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants