Skip to content

Remove CTA validation variants #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2020
Merged

Remove CTA validation variants #720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 0 additions & 34 deletions app/src/androidTest/java/com/duckduckgo/app/statistics/VariantManagerTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,40 +68,6 @@ class VariantManagerTest {
assertTrue(variant.hasFeature(SuppressDefaultBrowserCta))
}

// CTA Validation experiments

@Test
fun ctaControlVariantIsInactiveAndHasNoFeatures() {
val variant = variants.firstOrNull { it.key == "mq" }
assertEqualsDouble(0.0, variant!!.weight)
assertEquals(0, variant!!.features.size)
}

@Test
fun ctaSuppressDefaultBrowserVariantIsInactiveAndHasSuppressDefaultBrowserFeature() {
val variant = variants.firstOrNull { it.key == "mr" }
assertEqualsDouble(0.0, variant!!.weight)
assertEquals(1, variant!!.features.size)
assertTrue(variant.hasFeature(SuppressDefaultBrowserCta))
}

@Test
fun ctaSuppressWidgetVariantIsInactiveAndHasSuppressWidgetCtaFeature() {
val variant = variants.firstOrNull { it.key == "ms" }
assertEqualsDouble(0.0, variant!!.weight)
assertEquals(1, variant!!.features.size)
assertTrue(variant.hasFeature(SuppressWidgetCta))
}

@Test
fun ctaSuppressAllVariantIsInactiveAndHasSuppressCtaFeatures() {
val variant = variants.firstOrNull { it.key == "mt" }
assertEqualsDouble(0.0, variant!!.weight)
assertEquals(2, variant!!.features.size)
assertTrue(variant.hasFeature(SuppressDefaultBrowserCta))
assertTrue(variant.hasFeature(SuppressWidgetCta))
}

// CTA on Concept Test experiments

@Test
Expand Down
6 changes: 0 additions & 6 deletions app/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,6 @@ interface VariantManager {
filterBy = { isEnglishLocale() }),
Variant(key = "md", weight = 0.0, features = listOf(SuppressWidgetCta, SuppressDefaultBrowserCta), filterBy = { isEnglishLocale() }),

// Validate CTAs experiment
Variant(key = "mq", weight = 0.0, features = emptyList(), filterBy = { noFilter() }),
Variant(key = "mr", weight = 0.0, features = listOf(SuppressDefaultBrowserCta), filterBy = { noFilter() }),
Variant(key = "ms", weight = 0.0, features = listOf(SuppressWidgetCta), filterBy = { noFilter() }),
Variant(key = "mt", weight = 0.0, features = listOf(SuppressWidgetCta, SuppressDefaultBrowserCta), filterBy = { noFilter() }),

// Insert CTAs on Concept test experiment
Variant(key = "mu", weight = 1.0, features = emptyList(), filterBy = { isEnglishLocale() }),
Variant(key = "mv", weight = 1.0,
Expand Down