Skip to content

Conversation

@malmstein
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/1157893581871903/1162814661890319

Description:
When the user selected Light Mode, the navigation bar was still showed in Dark. This PR fixes that.

Fixes: #695

Steps to test this PR:

  1. Open current app in Google Play
  2. Open Settings and select Light Theme
  3. Check that Navigation bar is shown in Dark

Building this branch

  1. Open app
  2. Open Settings and select Light Theme
  3. Check that Navigation bar is shown in Light

Screenshots:

Before After
device-2020-02-24-092707 device-2020-02-24-092531

Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! However it doesn't work on Lollipop, how about removing the <item name="android:navigationBarColor">yourColorHere</item> from the specific themes and moving it to the top level one? That would make it work for all the versions.

DarkThemeLollipop

Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed we can't change the navigation bar color prior 23 because we cannot change the icon colors so it would display white on white for APIs below 23. Looks like LG does something specific 🤷‍♂.

@malmstein
Copy link
Contributor Author

Yeah! Some OEMs apparently did the right thing and tinted the color of the icons in the navigation bar pre v23. We can't rely on that for all devices, so for that reason we need to leave a dark navigation bar pre v23 even if the light theme is selected.

@malmstein malmstein merged commit acd30fa into develop Feb 24, 2020
@malmstein malmstein deleted the feature/david/light_navigation_bar branch February 24, 2020 12:21
cmonfortep added a commit that referenced this pull request Feb 28, 2020
@malmstein malmstein restored the feature/david/light_navigation_bar branch February 28, 2020 11:33
cmonfortep added a commit that referenced this pull request Feb 28, 2020
* Revert "light theme will now use light navigation bar (#722)"

This reverts commit acd30fa.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make the navigation bar light grey in light mode

2 participants