-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add alternative onboarding for interstitial search users #738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # app/src/main/java/com/duckduckgo/app/systemsearch/SystemSearchViewModel.kt
# Conflicts: # app/src/main/res/values-pt/strings.xml
cmonfortep
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested this as it's assigned to Craig. But I just left some optional comments. Good work here.
app/src/main/java/com/duckduckgo/app/systemsearch/SystemSearchViewModel.kt
Show resolved
Hide resolved
app/src/androidTest/java/com/duckduckgo/app/statistics/VariantManagerTest.kt
Show resolved
Hide resolved
CDRussell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
app/src/androidTest/java/com/duckduckgo/app/systemsearch/SystemSearchViewModelTest.kt
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/global/view/ViewExtension.kt
Outdated
Show resolved
Hide resolved
|
@CDRussell great point about the text, I had been overzealous using large margins and max width constraints. I have reduced the margins and this frees up more space on smaller screens while still keeping everything identical on larger screens. |
…gins as per PR feedback

Task/Issue URL: https://app.asana.com/0/inbox/361428290920650/1163294449813158/1165440117435986
Description:
Users may experience our app initially via our new interstitial search screen by launching the widget or future system search box and thus skip our initial in-app onboarding. This PR adds an alternative onboarding experience for these users.
Steps to test this PR:
Test new onboarding:
Test that completing in-app onboarding suppresses interstitial onboarding:
Internal references:
Software Engineering Expectations
Technical Design Template