Hotfix/5.47.1.fixes #747
Merged
Hotfix/5.47.1.fixes #747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malmstein
requested review from
CDRussell,
cmonfortep,
marcosholgado and
subsymbolic
as code owners
CDRussell
reviewed
Mar 20, 2020
Member
CDRussell
left a comment
CDRussell
left a comment
There was a problem hiding this comment.
I haven't had time for a full test, so just adding some comments from skim reading it.
Hoping that @cmonfortep can do the full review. If not, I can review fully on Monday.
app/src/main/java/com/duckduckgo/app/notification/AndroidNotificationScheduler.kt
Outdated
Show resolved
Hide resolved
Contributor
|
Taking this one @CDRussell @malmstein. |
cmonfortep
approved these changes
Mar 20, 2020
Contributor
cmonfortep
left a comment
cmonfortep
left a comment
There was a problem hiding this comment.
LGTM. Not sure if there's any difference between cancelUniqueWork and cancelAllWorkByTag tho. Tested and it's working fine.
Tested this:
- Replace
DaysforMinuteswhen scheduling workers. - Fresh install with this branch and open the app to schedule notifications.
- Rename workers parent class.
- Install again.
- Open the app to schedule new notifications.
- Wait a some minutes to receive notifications.
Results:
- Privacy notification appeared ✅
- Error appeared in console for
SearchPromptNotificationWorker✅ This was expected as we don't cancel those type of notifications. SearchPromptNotificationappeared ✅(this one was the one scheduled after renaming the parent class)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/inbox/1157893581871899/1119619712088571/1167491198050484
Description:
Renaming
NotificationSchedulerintroduced a bug that made it impossible forDaggerWorkerFactoryto create Workers. The classpath had changed and therefore no longer possible to find.This PR fixes this issue, also adding a layer of security in
DaggerWorkerFactorypreventing it from crashing if the worker can't be found.As part of this PR we also fixed a new issue that was introduced with the Change App Icon feature. On some devices the
themeResourceIdwas not found after changing the icon, so we added a default option for that too based on theAppTheme