Skip to content

Conversation

@cmonfortep
Copy link
Contributor

@cmonfortep cmonfortep commented Apr 1, 2020

Task/Issue URL: https://app.asana.com/0/0/1169355936992923/f
Tech Design URL: https://app.asana.com/0/0/1169315285491563/f
CC:

Description:
When making the new onboarding and Dax dialogs the new default experience, we noticed that the UI for some big screens (specially tablets) could be improved. To avoid delaying the release, we decided just to introduce a few quick improvements. Those include:

  • introducing a max width of 600dp for all devices
  • centering the dialog

Onboarding dialog
Screenshot_1585744086
Screenshot_1585744094

Intro dialog:
Screenshot_1585744107
Screenshot_1585744114

Dax dialog:
Screenshot_1585744125
Screenshot_1585744130

Steps to test this PR:

  1. Fresh install on a big screen device -> use a tablet
  2. Ensure this first dialog during the onboarding process is shown as the attached image
  3. Navigate to the browser screen
  4. Ensure intro dialog is shown as the attached image (test it in both modes portrait and landscape)
  5. Visit a site to trigger any Dax dialog (cnn.com)
  6. Ensure Dax dialog si shown as the attached image (test it in both modes portrait and landscape)

Additional test:

  1. you can try running the same flow on a phone
  2. Ensure everything looks as before, except for some devices in landscape mode where the same rules should apply (max 600dp and centered)

Side note: COVID Cta stays as it is right now.


Internal references:

Software Engineering Expectations
Technical Design Template

- changing alignment and max-width for dax dialogs
@cmonfortep cmonfortep changed the title Quick dialogs improvements on big screens Android: Dax Dialogs - quick improvements on big screens Apr 1, 2020
@malmstein malmstein self-assigned this Apr 1, 2020
Copy link
Contributor

@malmstein malmstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on a nexus 9 looks good. just one comment about a dimension

app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent" />
app:layout_constraintTop_toTopOf="parent"
app:layout_constraintWidth_max="600dp"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are using this value 4 times, maybe it makes sense to extract as a dimension?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I know they are the same number, but it's just because the same size worked well to constraint each dialog for the different screens. But there's no indication that if at some point we need to tweak one of those dialogs, the rest should change too. So they are not officially related between them.

@cmonfortep cmonfortep merged commit ea88c24 into develop Apr 1, 2020
@cmonfortep cmonfortep deleted the feature/cristian/improve_dax_dialogs_tablet branch April 1, 2020 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants