Pressing back after dismissing keyboard in find in page close find in page view #797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewR8
requested review from
CDRussell,
cmonfortep,
malmstein,
marcosholgado and
subsymbolic
as code owners
cmonfortep
approved these changes
May 12, 2020
Contributor
cmonfortep
left a comment
cmonfortep
left a comment
There was a problem hiding this comment.
LGTM Thanks for the contribution. I liked you introduced a test for the new logic. 👍
Sorry for the delay on the review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue URL: #686
Steps to test this PR:
1.Navigate to Find in page
2.Click on back button on browser